Fixing category indexing #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HDembinski Let me know if this seems like a reasonable workaround for 0.6.2; I assume Boost.Histogram will later add utilities that will make this easier. A single item no longer becomes a slice of length 1, and the trick shown on Gitter is used to produce the output. This also fixes sums over category axes, which were trying to slice in 0.6 and so were failing. TODO: This internally tests sums over category axes in the tests now, but that should be added as an explicit test in the future to be safe when the algorithm changes. |
henryiii
force-pushed
the
henryiii-catind
branch
from
dbdeb91
to
c128620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with indexing and summing category axes. You can now sum over a category axes again (regression in 0.6.0), and you can select a single item from a category axes just like you can from other axes types.
Fixes #297, improves #296 (single item selection now works on a category axis).
This may be improved upstream in Boost.Histogram later, in which case this can be simplified eventually.